search

shivas / versioning-bundle

Simple way to version (semantic versioning 2.0.0) your Symfony2/3/4/5/6 application
MIT License
111 stars 30 forks source link

Support PHP 8 #74

Closed xvilo closed 3 years ago

xvilo commented 3 years ago

This MR adds support for PHP 8. The unit tests seem to pass. As this is my first time contributing, please let me know if you want things differently :)

$ php -v
PHP 8.0.0 (cli) (built: Nov 27 2020 17:41:45) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies

$ ./vendor/bin/phpunit
PHPUnit 8.5.14 by Sebastian Bergmann and contributors.

Testing Default
.............................                                     29 / 29 (100%)

Time: 142 ms, Memory: 6.00 MB

OK (29 tests, 31 assertions)
xvilo commented 3 years ago

Ah, I now noticed https://github.com/shivas/versioning-bundle/pull/70 will wait for this