search

shivas / versioning-bundle

Simple way to version (semantic versioning 2.0.0) your Symfony2/3/4/5/6 application
MIT License
111 stars 30 forks source link

Fix GitDescribeFormatter prerelease versions #91

Closed nitwhiz closed 1 year ago

nitwhiz commented 1 year ago

closes #90

nitwhiz commented 1 year ago

ping?

dontub commented 1 year ago

Sorry for the delay, and thanks for the reminder :-) In #90 you suggested to add the commit hash as build metadata (separated by +). I agree that it would be the better choice. Any reason for not doing it like that?

nitwhiz commented 1 year ago

I wanted to keep the changes as non-invasive as possible. Also, this is closer to what git describe outputs itself.

I think if you want a specific format like this, library users should write a custom provider for that :)

dontub commented 1 year ago

All right. Thanks for the PR!

nitwhiz commented 1 year ago

Are there already plans on releasing a new patch version? I'd like to use this fix in a project at work, as this problem slightly impacts the stability of the deployment of our staging environment.

dontub commented 1 year ago

Since there was no reason for not publishing a new release I just tagged version 4.0.3.