search

shivas / versioning-bundle

Simple way to version (semantic versioning 2.0.0) your Symfony2/3/4/5/6 application
MIT License
112 stars 30 forks source link

support Symfony 7 #93

Closed sorrx closed 7 months ago

sorrx commented 10 months ago

updated composer symfony packages version constraints to support symfony 7

dontub commented 9 months ago

Thanks! Can you also adapt the Github workflow so the tests are executed with Sf 7, too?

sorrx commented 9 months ago

I tried adjusting the github workflow - but it won't work (yet). The newer dev-master of nyholm/symfony-bundle-test supports symfony 7, but this version breaks backwards-compatibility (Class "Nyholm\BundleTest\BaseBundleTestCase" doesn't exist anymore). I don't know, if or how it's possible, to tell phpunit to use different tests for different symfony versions/installed packages. Alternatively the BundleInitializationTest.php has to be rewritten to match the new dependencies - but that would exclude older symfony versions < 5.4 from testing.

So if anyone can offer a solution to this dependency-chaos - you're most welcome!

dontub commented 9 months ago

Dropping the support for unmaintained versions of Sf would be fine for me if it allows to keep the code more simple.

xvilo commented 9 months ago

any progress on this? :D

sorrx commented 7 months ago

Can you squash all the commits together to one?

Done!

Sorry, for the delay and thanks for your patience!

no worries - thanks for maintaining the bundle!

xvilo commented 7 months ago

@dontub can you take another look for us 👀. That would be highly appreciated

dontub commented 7 months ago

It's now released as 4.1.0. Thanks @sorrx for sticking at it.