shivasiddharth / GassistPi

Google Assistant for Single Board Computers
Other
1.02k stars 304 forks source link

Update gassist-installer.sh #1096

Closed aandroide closed 3 years ago

aandroide commented 3 years ago

uninstall automatic updates

shivasiddharth commented 3 years ago

Can this be moved to the top ? Before all the installation processes start ?

shivasiddharth commented 3 years ago

We could have it here https://github.com/shivasiddharth/GassistPi/blob/da41245cadbf7844defedae6514568dab1a65e14/scripts/gassist-installer.sh#L36

Also, please check as to what happens if this command is executed multiple times.

aandroide commented 3 years ago

pi @ raspberrypi: ~ $ sudo apt remove unattended-upgrade -y Reading package list ... Done Dependency tree generation Read status information ... Done E: The unattended-upgrade package could not be found pi @ raspberrypi: ~ $ sudo apt remove unattended-upgrade -y Reading package list ... Done Dependency tree generation Read status information ... Done E: The unattended-upgrade package could not be found

aandroide commented 3 years ago

I took your advice

shivasiddharth commented 3 years ago

E: The unattended-upgrade package could not be found

Seems like an error prompt. It could cause the installer script to exit. The script needs to check if the "unattended-upgrade" is present and only then run the command.

aandroide commented 3 years ago

I corrected and the script was not blocked. see if it's okay.

shivasiddharth commented 3 years ago

Have you checked by running the script ? I dont have time now to run the checks. If you can confirm if it works, i will merge the pull request.

aandroide commented 3 years ago

yes i created a new sh file to try with my function and right after i added sudo apt update and it ran without errors

shivasiddharth commented 3 years ago

What happens if you executed that sh (bash) script multiple times ? I am just making sure that everything is alright.

aandroide commented 3 years ago

Cattura0 prova

shivasiddharth commented 3 years ago

Ok thanks

shivasiddharth commented 3 years ago

Seems like this for Ubuntu system does not work on Pi. I have reverted the changes.