Made YouTube work again (dislike_count)

ContraNL commented 2 years ago

IMPORTANT NOTICE
If you do not complete the template below it is likely that your issue will not be addressed. When providing information about your issue please be as extensive as possible so that it can be solved by as little as possible responses.

FAILURE TO COMPLETE THE REQUESTED INFORMATION WILL RESULT IN YOUR ISSUE BEING CLOSED

Which branch of GassistPi are you using ? latest

Board and OS details:

Open a terminal and run

cat /proc/cpuinfo  
cat /etc/os-release  
cat /etc/rpi-issue

Paste your Board and OS details here.

Describe the bug:

YouTube not working right and wrong Dutch translation in keywords

Did you go through or search the issues section to check if your issue was already discussed (either currently open issues or closed issues)?

Yes

2. Is the issue related to assistant installation ?

No

If answer to question 2 is Yes, then attach the contents of terminal as a file or paste it below.

If answer to question 2 is No, then proceed further.

3. Does the assistant service start normally?

Yes

4. Is the assistant service restarting automatically?

No

If answer to question 4 is Yes, then paste the contents of the terminal below.

If answer to question 4 is No, then proceed further.

Manually start the assistant. For guidelines to start the assistant manually refer this

Paste the command below, that crashed the assistant

'dislike_count'

Paste the contents of the terminal below

Not necessary, did the work for you

Hi @shivasiddharth ,

I like your project and would like to tribute a little seeing I had a problem getting YouTube to work right. First of when I changed the language to Dutch I only got some weird link and after troubleshooting I found out that Play has not been translated to the best word

So if possible please change keywords_nl.yaml so that Play: 'spelen' is changed to Play: 'speel' This because spelen is plural to speel and you want to play one thing.

After that I ran into the 'dislike_count' error I have seen people mention before. I found out that this problem resides within pafy.

If you go into backend_youtube_dl.py and comment "self._dislikes = self._ydl_info['dislike_count']" verything works great. This may be because of the changes YouTube made to counteract the dislike wars.

Hope this helps, keep up the great work!!

shivasiddharth commented 2 years ago

I fixed the YouTube issue sometime back. SO its should work now. It would be great if you can take a look into the https://github.com/shivasiddharth/GassistPi/blob/master/src/keywords_nl.yaml keywords file suggest changes to make it close the actual language !

ContraNL commented 2 years ago

For me downloading 5.0 it did not. So maybe you can update the releases? Attached I have also included the altered keywords_nl document, I don't know if you support multiple translations for all values so check the changed information to see if you support it in your code.

I've also noticed that GassistPi crashes if you say 'from Spotify' wrong. So if you would say "Play ... on Spotify" (in Dutch) the application crashes and starts up again. I will try and find the problem, correct it, and come back to this issue to inform you of the changes I made.

keywords_nl.zip

shivasiddharth commented 2 years ago

I have changed the setup script for the pafy (dislike) issue. It will install a fork of the pafy git.

shivasiddharth commented 2 years ago

Do not try the Bullseye yet ! Its a mess.

ContraNL commented 2 years ago

I know, I first started out this project with Bullseye but after trying to change your code as well as that of Magic Mirror I soon realised I would have to rewrite too much. Therefor I reflashed to Buster.

I hope to have some time for the Spotify crash tomorrow. Will let you know.

shivasiddharth commented 2 years ago

Spotify has changed a bit. You need to mention the localhost:8888 address in the app that you create online. After you enable Spotify in the config file, and when you start the assistant for first time, you will be prompted for authentication. If 8888 port is not working change it to 8080.

ContraNL commented 2 years ago

I know, I followed your guide and found the option when clicking on edit at the created app. When I login and say remember login that part works.

I even see the Playlist names in the log but after that it crashes.

ContraNL commented 2 years ago

I have re-authenticated after the shutdown last time and everything regarding Spotify is working now. Is there a way so you don't have to re-authenticate everytime the raspberry has a shutdown for a day or more?

I want to use this as a Magic Mirror project and as such it won't be started every day. I want to power it on using a button connected to a smart plug that will start the pi as well as the display.

Hope to hear from you.

shivasiddharth commented 2 years ago

Spotify authentication needs to be done once only as per my experience I last time used it. But, Google assistant needs to be re-authenticated frequently. Thats because, Google decided to modify something.

shivasiddharth / GassistPi