shizmob / pydle

An IRCv3-compliant Python 3 IRC library.
BSD 3-Clause "New" or "Revised" License
154 stars 47 forks source link

Remove not used coroutine import #188

Closed danigm closed 1 year ago

danigm commented 1 year ago

coroutine is removed from python since python 3.11, it's imported in the init.py file but not used anywhere so that can be removed safely.

Rixxan commented 1 year ago

At present, Pydle only supports Python versions 3.6-3.10, so this isn't an issue with currently supported versions, however, I agree that it appears to be unused and should be removed. Initial testing looks like Pydle (on 3.8) doesn't complain if this import is gone.

Pydle does not currently support Python 3.10 or 3.11 (See issue #162 and PR #180) but this is a needed fix for when Pydle looks into 3.11 support.

All in all, LGTM :)