search

shiznix / unity-gentoo

A Gentoo overlay to install the Unity desktop
70 stars 13 forks source link

mostly ANBOX improvements #221

Closed okias closed 4 years ago

shiznix commented 4 years ago

Hi David thanks for taking the time to improve on this, I'll try to address each commit in turn.

  1. Gentoo's dev-cpp/gtest does not cover the overlay's dev-cpp/{gtest,gmock} - compare the files installed and you'll see the Gentoo implementation is largely incomplete, it's that reason alone why it's maintained in the overlay (other ebuilds within the overlay need the more complete versions).

  2. Removal of dev-libs/dbus-cpp from app-emulation/anbox DEPEND is a good pickup, I see upstream have replaced it's functionality with sys-apps/systemd (ref. https://github.com/anbox/anbox/commit/f1480bfb914bee4a0a564b9e67deab51342684f6 )

  3. Anbox only requires LXC, not LXD (note that LXC is also a default required dep. for LXD)

  4. There are some good improvements to dev-libs/properties-cpp here and by popular demand it could probably be decoupled from requiring the user to use the overlay's Unity profiles.

shiznix commented 4 years ago

Fixed in commit 09a07420936a5a334d1e65e267ea413905c23005