shizuko-akamoto / Trecipe

CPSC 436I Project (2020S)
1 stars 3 forks source link

#28 implement context filter #35

Closed shumal1 closed 4 years ago

shumal1 commented 4 years ago

Please see commit log, closes #28

shumal1 commented 4 years ago

@shizuko-akamoto Done addressing comments, let me know if it works.

shizuko-akamoto commented 4 years ago

@shizuko-akamoto Done addressing comments, let me know if it works.

Sorry, just a bit more styling issues:

  1. let's remove the shadow effect on hover contextFilterSelectorEntry
  2. The chevron up and down of selector look better if it's aligned to right side of the box Like this: image Just move the justify-content: flex-start from .contextFilterSelector to .contextFilterSelectorEntry.
  3. I realized after you extended .button and .contextFilterSelector in places, most of the stylings to on :hover and :active are duplicated. Removed them and the component still look the same.

(before u start getting annoyed LOL, here's a quicker fix, just copy + replace these in 😛)

.contextFilterSelector{
  @extend .button;
  border: 8px;
  width: 140px;
  padding: 0 1em;
}

.contextFilterSelectorEntry{
  @extend .contextFilterSelector;
  border-radius: 0;
  width: 140px;
  text-align: left;
  justify-content: flex-start;
}

.contextFilterSelectorList {
  list-style: none;
  padding: 0;
  margin: 0;
  background-color: $tc-white;
}

After those changes, I'm good with these two components.

shumal1 commented 4 years ago

Done addressing comments.