search

shizunge / endlessh-go

A golang implementation of endlessh exporting Prometheus metrics, visualized by a Grafana dashboard.
GNU General Public License v3.0
977 stars 31 forks source link

Use config File #88

Open sudo-Tiz opened 9 months ago

sudo-Tiz commented 9 months ago

Add the ability to use a yaml/toml configuration file. To my point of view cli_args should either define a configuration file either define args directly.

sudo-Tiz commented 9 months ago

I am working on an ansible role to integrate endlessh-go to the mash playbook . Since this playbook is designed for production use, it would be preferable for the endlessh-go code to adhere to "good practice standards," such as the utilization of a config file. I opted for endlessh-go instead of the more popular endlessh implementation in C due to its superior log handling capabilities. However, I must emphasize that I am not proficient in go development. Therefore, I have submitted a pull request (#90), which requires review and refinement in order to cater to all possible use cases. It would be greatly appreciated if you could consider addressing this issue as a "good first issue."