search

shizunge / endlessh-go

A golang implementation of endlessh exporting Prometheus metrics, visualized by a Grafana dashboard.
GNU General Public License v3.0
977 stars 31 forks source link

Feat: yaml config file #90

Open sudo-Tiz opened 9 months ago

sudo-Tiz commented 9 months ago

I am currently on smartphone and i can't test the code (linked to #88 )

sudo-Tiz commented 9 months ago

Code have to be modified to set the default value if not defined neither in the config-file neither in cli args

shizunge commented 9 months ago

Thanks for the CL.

However we need more cleanup before checkin this: As now we have two ways to setup the config, and we may add env in the future, I would like to move the corresponding code to their own package.

In the mean time, you can help

We can have docs as specification, and examples as test input before implementing things.

shizunge commented 3 weeks ago

Current roadmap:

  1. Create integration tests, including tests of the CLI arguments.
  2. Update github actions
  3. Read config file from yaml and/or ENV. traefik is doing it, we may borrow some codes there. (Note: traefik is under MIT license)
  4. Build a new data processing pipeline, updating Prometheus metrics will be one stage of the pipeline.
  5. enable-abuseipdb reporting, which will be a parallel stage of updating Prometheus metrics.

I will review this CL when we finish previous steps.

This CL is at step 3 above.