search

shkhln / linuxulator-steam-utils

Steam launcher for FreeBSD
MIT License
129 stars 13 forks source link

Dependencies repository hardcoding #95

Closed Tectu closed 1 year ago

Tectu commented 2 years ago

The Makefile contains this dependencies target:

dependencies:
    pkg install -r FreeBSD ${DEPS} ${NVIDIA_DEPS}

Is there any particular reason why the repository is hardcoded? In a scenario where a user isn't using the official FreeBSD packages this results in failure of installation of the packages although the packages are available in a pkg repository (just not the FreeBSD one).

koobs commented 2 years ago

Explicit > Implicit when the system/user environment is unknown, resulting in a better user experience (error condition handled) in the case where the system defaults have been changed.

shkhln commented 2 years ago

I have no idea, that part was in https://github.com/shkhln/linuxulator-steam-utils/pull/2.

Tectu commented 2 years ago

Explicit > Implicit when the system/user environment is unknown, resulting in a better user experience (error condition handled) in the case where the system defaults have been changed.

Except that now in a scenario like mine (custom poudriere repo) I can't use the dependencies target at all (without modifying the makefile). Is putting road blocks in front of more experienced users really the sacrifice needed to provide a "better user experience when the environment is unknown"?

I might still be missing something here. Would just simply removing the -r FreeBSD parameter result in this still working for pretty much everyone who tries to use this out-of-the-box while also working for people with custom package repos?

shkhln commented 2 years ago

Again, the only thing I know about pkg and multiple repositories is "don't". You'll have to ask @dch how that is supposed to work.