Major change: - Githubissues

shklar / SubMinimizer

Detect and delete unused resources in your Azure subscriptions and save money

4 stars 1 forks source link

Major change: #111

Closed shklar closed 4 years ago

shklar commented 4 years ago

Removing the option for auto delete
Supporting mark for delete for report only subscriptions
Added list of marked for delete resources to email
Refactoring to allow testability
Comprehensive unit tests for the subscription analyzer
Removing the tenant ID that has been passed around everywhere and replacing it with configuration

bergano65 commented 4 years ago

donem

From: Maxim Shklar notifications@github.com Sent: Thursday, February 27, 2020 9:43 AM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [shklar/SubMinimizer] Major change: (#111)

Removing the option for auto delete
Supporting mark for delete for report only subscriptions
Added list of marked for delete resources to email
Refactoring to allow testability
Comprehensive unit tests for the subscription analyzer
Removing the tenant ID that has been passed around everywhere and replacing it with configuration

You can view, comment on, or merge this pull request online at:

https://github.com/shklar/SubMinimizer/pull/111 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F111&data=02%7C01%7Ceviten%40microsoft.com%7Cd216ef296a8f458c25d908d7bb58b1dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637183861927823869&sdata=R9e7UXI6EkPYahLEfnLWK524L43Uo7QW%2B6SdeSITu80%3D&reserved=0

Commit Summary

Major change:

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F111%3Femail_source%3Dnotifications%26email_token%3DAEIJKLFBTPMOU36LDOMUW6TRE5VI5A5CNFSM4K4VRV52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQWHZSQ&data=02%7C01%7Ceviten%40microsoft.com%7Cd216ef296a8f458c25d908d7bb58b1dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637183861927953796&sdata=WOmr%2FwozB%2Bf9AbTM1eqTkt4nkdwp2qHh8fKSo9ABLlY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEIJKLC37AELHSOTSJ3TKRDRE5VI5ANCNFSM4K4VRV5Q&data=02%7C01%7Ceviten%40microsoft.com%7Cd216ef296a8f458c25d908d7bb58b1dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637183861927963784&sdata=Wb6L%2FGU9HpI45Ve6twZoOSFwXW95jWaCnK8YXZHvB0k%3D&reserved=0.