shklar / SubMinimizer

Detect and delete unused resources in your Azure subscriptions and save money
4 stars 1 forks source link

main view fix #49

Closed bergano65 closed 7 years ago

bergano65 commented 7 years ago

link learn more by my opinion is informative in main view so decided not remove it

bergano65 commented 7 years ago

Ok, I’ll synchronize sources and will send again. Afterwards will fix message for reset resources, wait day before subscription will be analyzed and my resources filtering issue. In this order. Afterwards will remain only analyze view fix (most extensive fix) and collecting statistics for subscriptions feature.

From: Maxim Shklar [mailto:notifications@github.com] Sent: Saturday, December 24, 2016 2:15 PM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Evgeny Vitenberg eviten@microsoft.com; Author author@noreply.github.com Subject: Re: [shklar/SubMinimizer] main view fix (#49)

@shklar requested changes on this pull request.


In CogsMinimizer/Views/Home/Index.cshtmlhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F49%23pullrequestreview-14357768&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=dnlDtcPZAUG2jSQAahEkA9Bt8VeAd0QaPfuBUgdduUo%3D&reserved=0:

@@ -34,7 +34,7 @@

 {

     <div class="col-lg-4 thumbnail">

         <div class="caption">

There is a conflict in this file. Please resolve it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F49%23pullrequestreview-14357768&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=dnlDtcPZAUG2jSQAahEkA9Bt8VeAd0QaPfuBUgdduUo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLAXOzpkdtvIYdGYoZsJHs18DU5GAks5rLZlvgaJpZM4LURnE&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=QMqkLOmI18fbklVufGNjg42nTT14jjUE5F8iUhI6YdQ%3D&reserved=0.

bergano65 commented 7 years ago

To simplify merge and avoid excessive merge in history of main branch I’m deleting pull request and branch and will submit fix over existing main branch state.

From: Maxim Shklar [mailto:notifications@github.com] Sent: Saturday, December 24, 2016 2:15 PM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Evgeny Vitenberg eviten@microsoft.com; Author author@noreply.github.com Subject: Re: [shklar/SubMinimizer] main view fix (#49)

@shklar requested changes on this pull request.


In CogsMinimizer/Views/Home/Index.cshtmlhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F49%23pullrequestreview-14357768&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=dnlDtcPZAUG2jSQAahEkA9Bt8VeAd0QaPfuBUgdduUo%3D&reserved=0:

@@ -34,7 +34,7 @@

 {

     <div class="col-lg-4 thumbnail">

         <div class="caption">

There is a conflict in this file. Please resolve it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F49%23pullrequestreview-14357768&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=dnlDtcPZAUG2jSQAahEkA9Bt8VeAd0QaPfuBUgdduUo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLAXOzpkdtvIYdGYoZsJHs18DU5GAks5rLZlvgaJpZM4LURnE&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=QMqkLOmI18fbklVufGNjg42nTT14jjUE5F8iUhI6YdQ%3D&reserved=0.

bergano65 commented 7 years ago

Pls look submitted pull request. Minor changes just to finish main view fixes.

From: Evgeny Vitenberg Sent: Sunday, December 25, 2016 1:53 AM To: shklar/SubMinimizer reply@reply.github.com; shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [shklar/SubMinimizer] main view fix (#49)

To simplify merge and avoid excessive merge in history of main branch I’m deleting pull request and branch and will submit fix over existing main branch state.

From: Maxim Shklar [mailto:notifications@github.com] Sent: Saturday, December 24, 2016 2:15 PM To: shklar/SubMinimizer SubMinimizer@noreply.github.com<mailto:SubMinimizer@noreply.github.com> Cc: Evgeny Vitenberg eviten@microsoft.com<mailto:eviten@microsoft.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [shklar/SubMinimizer] main view fix (#49)

@shklar requested changes on this pull request.


In CogsMinimizer/Views/Home/Index.cshtmlhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F49%23pullrequestreview-14357768&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=dnlDtcPZAUG2jSQAahEkA9Bt8VeAd0QaPfuBUgdduUo%3D&reserved=0:

@@ -34,7 +34,7 @@

 {

     <div class="col-lg-4 thumbnail">

         <div class="caption">

There is a conflict in this file. Please resolve it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F49%23pullrequestreview-14357768&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=dnlDtcPZAUG2jSQAahEkA9Bt8VeAd0QaPfuBUgdduUo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLAXOzpkdtvIYdGYoZsJHs18DU5GAks5rLZlvgaJpZM4LURnE&data=02%7C01%7Ceviten%40microsoft.com%7Ccc968099babd470de11f08d42c4a5522%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636182145160417027&sdata=QMqkLOmI18fbklVufGNjg42nTT14jjUE5F8iUhI6YdQ%3D&reserved=0.