shklar
commented
7 years ago Yes. Tho is not a scenario we are targeting right now.
Sent from my Windows Phone
From: bergano65mailto:notifications@github.com Sent: 01/01/2017 15:18 To: shklar/SubMinimizermailto:SubMinimizer@noreply.github.com Cc: Maxim Shklarmailto:maximsh@microsoft.com; Mentionmailto:mention@noreply.github.com Subject: Re: [shklar/SubMinimizer] Tenants with application not registered proceeded right now (#55)
If somebody manually will authorize our application at his tenant this code will work automatically. Still think we should hard code it?
From: Maxim Shklar [mailto:notifications@github.com] Sent: Sunday, January 1, 2017 4:56 AM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Evgeny Vitenberg eviten@microsoft.com; Author author@noreply.github.com Subject: Re: [shklar/SubMinimizer] Tenants with application not registered proceeded right now (#55)
@shklar requested changes on this pull request.
@@ -67,15 +67,39 @@ public static List
GetUserOrganizations()
string responseContent = response.Content.ReadAsStringAsync().Result;
var organizationsResult = (Json.Decode(responseContent)).value;
-
string objectIdOfCloudSenseServicePrincipal = null;
foreach (var organization in organizationsResult)
We already know the ID of AAD. Why not just add it to our configuration?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F55%23pullrequestreview-14813114&data=02%7C01%7Ceviten%40microsoft.com%7C86ecdf310df34dbb7dbf08d432457f0b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188721449609685&sdata=MS2A2RTza7EVuifjVpc4Z%2FmDcAk18tFjSDiikAEzUv0%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLFluTitNKiBwzbRav7ZqfzA8dxOaks5rN6JNgaJpZM4LYnAS&data=02%7C01%7Ceviten%40microsoft.com%7C86ecdf310df34dbb7dbf08d432457f0b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188721449609685&sdata=cZbSHkxQwTVyI29FbsStnVWWcdC9vUGIrLpAfhbkgmQ%3D&reserved=0.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F55%23issuecomment-269902705&data=02%7C01%7Cmaximsh%40microsoft.com%7C33030fd2929749e8bfe108d43248a9c0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188735047135782&sdata=eETfZD6iuRuIuKq7HDvbmFqqEEsjF7gUxl8lWE71AnE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPVAdmwdOFOmcoOQrpHTWWzQsVCrHeLEks5rN6ecgaJpZM4LYnAS&data=02%7C01%7Cmaximsh%40microsoft.com%7C33030fd2929749e8bfe108d43248a9c0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188735047135782&sdata=cfFArEDVmJN8WItKzOvB2tQh4J51GRQIw9oWDCHK7eo%3D&reserved=0.
bergano65
If somebody manually will authorize our application at his tenant this code will work automatically. Still think we should hard code it?
From: Maxim Shklar [mailto:notifications@github.com] Sent: Sunday, January 1, 2017 4:56 AM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Evgeny Vitenberg eviten@microsoft.com; Author author@noreply.github.com Subject: Re: [shklar/SubMinimizer] Tenants with application not registered proceeded right now (#55)
@shklar requested changes on this pull request.
In Shared/AzureResourceManagerUtil.cshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F55%23pullrequestreview-14813114&data=02%7C01%7Ceviten%40microsoft.com%7C86ecdf310df34dbb7dbf08d432457f0b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188721449609685&sdata=MS2A2RTza7EVuifjVpc4Z%2FmDcAk18tFjSDiikAEzUv0%3D&reserved=0:
string objectIdOfCloudSenseServicePrincipal = null;
We already know the ID of AAD. Why not just add it to our configuration?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F55%23pullrequestreview-14813114&data=02%7C01%7Ceviten%40microsoft.com%7C86ecdf310df34dbb7dbf08d432457f0b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188721449609685&sdata=MS2A2RTza7EVuifjVpc4Z%2FmDcAk18tFjSDiikAEzUv0%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLFluTitNKiBwzbRav7ZqfzA8dxOaks5rN6JNgaJpZM4LYnAS&data=02%7C01%7Ceviten%40microsoft.com%7C86ecdf310df34dbb7dbf08d432457f0b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636188721449609685&sdata=cZbSHkxQwTVyI29FbsStnVWWcdC9vUGIrLpAfhbkgmQ%3D&reserved=0.