search

shklar / SubMinimizer

Detect and delete unused resources in your Azure subscriptions and save money
4 stars 1 forks source link

ResetResources resets all subscriptions #66

Open shklar opened 7 years ago

shklar commented 7 years ago

Should only reset the resources for the requested subscription of course.

bergano65 commented 7 years ago

I see the problem

From: Maxim Shklar [mailto:notifications@github.com] Sent: Tuesday, February 7, 2017 8:06 AM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [shklar/SubMinimizer] ResetResources resets all subscriptions (#66)

Should only reset the resources for the requested subscription of course.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fissues%2F66&data=02%7C01%7Ceviten%40microsoft.com%7Cc16dea81f5f340aff6fa08d44f732e4b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636220803487861249&sdata=qesqbz493SkwUCsx4XpeM2W5nIsI9ggSVyy8uxUK9jI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLFzoF0WdioSjVcaC0oSaMD7lpTDIks5raJZbgaJpZM4L5sC9&data=02%7C01%7Ceviten%40microsoft.com%7Cc16dea81f5f340aff6fa08d44f732e4b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636220803487861249&sdata=yrfcwIKvW3Xyc%2FQrlsvHjBViPYHzR3qnviOpnxPyXCA%3D&reserved=0.

bergano65 commented 7 years ago

Fixed but give me one day I’ll make this testable. Entity framework allows in memory storage instead of database server. With simple code refractory we will create test database in memory, fill it with subscriptions and resources and we’ll test that resources only of one selected subscription are reset.

Afterwards one step to do is mock azure calls and we will have completely testable application in any combination of real/mock data. After having database mocked I’ll keep in mind azure mock and will think about this executing another tasks.

From: Evgeny Vitenberg Sent: Tuesday, February 7, 2017 8:20 AM To: shklar/SubMinimizer reply@reply.github.com; shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: RE: [shklar/SubMinimizer] ResetResources resets all subscriptions (#66)

I see the problem

From: Maxim Shklar [mailto:notifications@github.com] Sent: Tuesday, February 7, 2017 8:06 AM To: shklar/SubMinimizer SubMinimizer@noreply.github.com<mailto:SubMinimizer@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: [shklar/SubMinimizer] ResetResources resets all subscriptions (#66)

Should only reset the resources for the requested subscription of course.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fissues%2F66&data=02%7C01%7Ceviten%40microsoft.com%7Cc16dea81f5f340aff6fa08d44f732e4b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636220803487861249&sdata=qesqbz493SkwUCsx4XpeM2W5nIsI9ggSVyy8uxUK9jI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLFzoF0WdioSjVcaC0oSaMD7lpTDIks5raJZbgaJpZM4L5sC9&data=02%7C01%7Ceviten%40microsoft.com%7Cc16dea81f5f340aff6fa08d44f732e4b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636220803487861249&sdata=yrfcwIKvW3Xyc%2FQrlsvHjBViPYHzR3qnviOpnxPyXCA%3D&reserved=0.

shklar commented 7 years ago

Excellent

Sent from my Windows Phone

From: bergano65mailto:notifications@github.com Sent: ‎08/‎02/‎2017 20:24 To: shklar/SubMinimizermailto:SubMinimizer@noreply.github.com Cc: Maxim Shklarmailto:maximsh@microsoft.com; Authormailto:author@noreply.github.com Subject: Re: [shklar/SubMinimizer] ResetResources resets all subscriptions (#66)

Fixed but give me one day I’ll make this testable. Entity framework allows in memory storage instead of database server. With simple code refractory we will create test database in memory, fill it with subscriptions and resources and we’ll test that resources only of one selected subscription are reset.

Afterwards one step to do is mock azure calls and we will have completely testable application in any combination of real/mock data. After having database mocked I’ll keep in mind azure mock and will think about this executing another tasks.

From: Evgeny Vitenberg Sent: Tuesday, February 7, 2017 8:20 AM To: shklar/SubMinimizer reply@reply.github.com; shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: RE: [shklar/SubMinimizer] ResetResources resets all subscriptions (#66)

I see the problem

From: Maxim Shklar [mailto:notifications@github.com] Sent: Tuesday, February 7, 2017 8:06 AM To: shklar/SubMinimizer SubMinimizer@noreply.github.com<mailto:SubMinimizer@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: [shklar/SubMinimizer] ResetResources resets all subscriptions (#66)

Should only reset the resources for the requested subscription of course.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fissues%2F66&data=02%7C01%7Ceviten%40microsoft.com%7Cc16dea81f5f340aff6fa08d44f732e4b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636220803487861249&sdata=qesqbz493SkwUCsx4XpeM2W5nIsI9ggSVyy8uxUK9jI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLFzoF0WdioSjVcaC0oSaMD7lpTDIks5raJZbgaJpZM4L5sC9&data=02%7C01%7Ceviten%40microsoft.com%7Cc16dea81f5f340aff6fa08d44f732e4b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636220803487861249&sdata=yrfcwIKvW3Xyc%2FQrlsvHjBViPYHzR3qnviOpnxPyXCA%3D&reserved=0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fissues%2F66%23issuecomment-278417186&data=02%7C01%7Cmaximsh%40microsoft.com%7C3a85100503dd4045917e08d4504fc3e0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636221750901040817&sdata=aJY7QCdLya9%2FIbWfRXgiGXSTrNDpoBf5p%2FHKFBBM9Fk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPVAdl5KSwIsIdrgcD9Gp2bdDKy22ulkks5raghugaJpZM4L5sC9&data=02%7C01%7Cmaximsh%40microsoft.com%7C3a85100503dd4045917e08d4504fc3e0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636221750901040817&sdata=C7sdCnhTTwaFHD%2F0LAK0F%2Bt8v%2FLIgMzvRuvLggyjSQ8%3D&reserved=0.