shklar / SubMinimizer

Detect and delete unused resources in your Azure subscriptions and save money
4 stars 1 forks source link

Register new subscription by providing a subscription name and ID. #93

Closed shklar closed 5 years ago

shklar commented 5 years ago

The user should assign reader role to Subminimizer prior to registering the subscription.

bergano65 commented 5 years ago

@Maxim Shklarmailto:maximsh@microsoft.com sorry why we don’t check in secret moving to Azure?

From: Maxim Shklar notifications@github.com Sent: Thursday, April 4, 2019 3:28 PM To: shklar/SubMinimizer SubMinimizer@noreply.github.com Cc: Evgeny Vitenberg eviten@microsoft.com; Review requested review_requested@noreply.github.com Subject: Re: [shklar/SubMinimizer] Register new subscription by providing a subscription name and ID. (#93)

@shklarhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar&data=02%7C01%7Ceviten%40microsoft.com%7C186f7b4ae98b4e12064b08d6b8f8fe29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899776891030135&sdata=wlP3ja71RtmanOIFAVds5%2FmMKZNrdCJ6X76xNl74MyA%3D&reserved=0 requested your review on: #93https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F93&data=02%7C01%7Ceviten%40microsoft.com%7C186f7b4ae98b4e12064b08d6b8f8fe29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899776891030135&sdata=c5Bxfrh7ZWQPm9x3X8FMVSHpUkJjXgvnYomyCKhsihg%3D&reserved=0 Register new subscription by providing a subscription name and ID..

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshklar%2FSubMinimizer%2Fpull%2F93%23event-2252756699&data=02%7C01%7Ceviten%40microsoft.com%7C186f7b4ae98b4e12064b08d6b8f8fe29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899776891030135&sdata=eD9fqli3MRzLODtS%2BQN6vCX4MUCQQDayWJByY1abF6s%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARCVLMiKQfapPPCsIdxEuKHTyMRra4e-ks5vde_WgaJpZM4ccrF_&data=02%7C01%7Ceviten%40microsoft.com%7C186f7b4ae98b4e12064b08d6b8f8fe29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899776891030135&sdata=YD%2BKcL%2Bp9%2B5tfeM1LUgXYMkdL136ef0%2Bx262k0Fn%2Fvg%3D&reserved=0.