shldhee / note

개인노트
0 stars 0 forks source link

React Hook useEffect has a missing dependency: 'xxx'. Either include it or remove the dependency array. (react-hooks/exhaustive-deps) #1

Open shldhee opened 3 years ago

shldhee commented 3 years ago

참고 : https://velog.io/@yjs3819/useEffect-dependency

function GitHubUser({ login }) {
  const [data, setData] = useState(loadJSON(`user:${login}`));

  useEffect(() => {
    if (!data) return;
    if (data.login === login) return;

    const { name, avatar_url, location } = data;
    saveJSON(`user:${login}`, {
      name,
      login,
      avatar_url,
      location
    })
  }, [data]); // 수정전
  }, [data, login]); // 수정후
...