search

shlevy / nix-exec

Run programs defined in nix expressions
MIT License
50 stars 6 forks source link

No IPC, no pain #5

Open ip1981 opened 9 years ago

ip1981 commented 9 years ago

Hi, Shea. PR isn't appropriate, thus the issue :-)

What do you think about this? https://github.com/zalora/nix-exec/commit/1d8b3af5873f1bf4edf013ad90f47627ca2fffd7

We can do similar thing for fetchgit.

shlevy commented 9 years ago

Two questions:

  1. What does this gain from being a nix-exec builtin instead of just being defined e.g. in defnix?
  2. How is this not IPC? Is it just that we use a shell instead of C++? fetchgit already does that...
ip1981 commented 9 years ago
  1. It doesn't matter right now
  2. No pipes => we can rely on vfork, no fork bomb. Both parent and child know how to find the result fetchgit uses pipes.
shlevy commented 9 years ago

Aaah, I see. Yeah good call, I'd love to fix fetchgit that way (been bit by ENOMEM on fork a few times there...)

shlevy commented 8 years ago

@ip1981 Any chance you want to implement this? :grin:

ip1981 commented 8 years ago

The short answer is no. I've been moving in some other way: git submodules and git-crypt.