acelaya
commented
2 years ago The base URL needs to include the leading bar, so in your case it should be /shlink, not shlink.
I'll try to improve the documentation to make it clear.
Edit 4: Deleting data/cache/fastroute_cached_routes.php was the missing magic sauce
This one is a bug. This particular option affects routes, which have a separated cached config. I missed this use case.
I'll get it fixed.
However, bin/cli short-url:list continues to return malformed Short URLs like https://example.com/shlink/shlink/ZJxAM.
I'll investigate this one.
How Shlink is set-up
Summary
The base path feature seems bugged. Short URLs return 404 errors, the API endpoints return 404 errors, and the CLI output does not look correct (though unfortunately this last issue seems cosmetic).
Current behavior
The
DEFAULT_DOMAINis set toexample.comand theBASE_PATHis set toshlinkingenerated-config.php, but theShort URLfield output bybin/cli short-url:listishttps://example.comshlink/shlink/ZJxAMinstead of the expectedhttps://example.com/shlink/ZJxAM. When trying to use the short URLhttps://example.com/shlink/ZJxAM, Shlink shows the generic 404 page and logs aregular_404error in the database.Edit 1: When
BASE_PATHis set to/s, theShort URLoutput becomeshttps://example.com/s/s/ZJxAM. Changing the nginx configuration to match does not solve the issue: Shlink still shows the generic 404 page and logs aregular_404error in the database (with thevisited_urlcorrectly logged ashttps://example.com/s/s/ZJxAM, suggesting the CLI output is wrong). I’ve tried settingBASE_PATHtos,/s,/s/, and leaving it empty and puttingexample.com/sin theDEFAULT_DOMAIN, all without luck.Edit 2: Now things are looking weird. Even when I configureBASE_PATHto be empty (theShort URLbecomeshttps://example.com/ZJxAM) and use nginx to rewrite the path before passing it on to openswoole so Shlink seeshttps://example.com/s/ZJxAMas justhttps://example.com/ZJxAM, I’m getting 404 errors.Edit 3: Deleted
data/cache/fastroute_cached_routes.php; solved the empty base path 404 problem in Edit 2. I will let nginx continue “lying” to Shlink for now as a workaround.Edit 4: Deleting
data/cache/fastroute_cached_routes.phpwas the missing magic sauce. It seems like I need to manually do this step every time I test a newBASE_PATHeven thoughvendor/bin/shlink-installer set-optionclaims it has “properly updated” the configuration. This would be a really great note to add to the troubleshooting documentation, along with an example of how to setBASE_PATHso people don’t need to guess whether to usepath(which doesn’t work) or/path(works) or/path/(haven’t tested)!Now I have confirmed that setting
BASE_PATHto/shlinkworks, redirectinghttps://example.com/shlink/ZJxAMas expected. However,bin/cli short-url:listcontinues to return malformedShort URLs likehttps://example.com/shlink/shlink/ZJxAM. At least it’s confirmed the issue is cosmetic.Expected behavior
When the
DEFAULT_DOMAINis set toexample.comand theBASE_PATHis set toshlinkingenerated-config.php, theShort URLfield output bybin/cli short-url:listshould behttps://example.com/shlink/ZJxAM, nothttps://example.comshlink/shlink/ZJxAM. When trying to use the short URLhttps://example.com/shlink/ZJxAM, Shlink redirects according to the configuration (301) and logs the visit normally in the database.How to reproduce
Install Shlink from the openswoole dist release on an Ubuntu 20.04 LTS Minimal Google Compute Engine instance with nginx and mariadb, configuring the default domain as
example.comand the base path asshlink.nginx configuration
``` server { listen %ip%:%web_ssl_port% ssl http2; server_name %domain_idn% %alias_idn%; root %docroot%; index index.php index.html index.htm; access_log /var/log/nginx/domains/%domain%.log combined; access_log /var/log/nginx/domains/%domain%.bytes bytes; error_log /var/log/nginx/domains/%domain%.error.log error; ssl_certificate %ssl_pem%; ssl_certificate_key %ssl_key%; ssl_stapling on; ssl_stapling_verify on; include %home%/%user%/conf/web/%domain%/nginx.hsts.conf*; location = /favicon.ico { log_not_found off; access_log off; } location = /robots.txt { allow all; log_not_found off; access_log off; } location ~ /\.(?!well-known\/) { deny all; return 404; } location / { try_files $uri $uri/ /index.php?$args; location ~* ^.+\.(ogg|ogv|svg|svgz|swf|eot|otf|woff|woff2|mov|mp3|mp4|webm|flv|ttf|rss|atom|jpg|jpeg|gif|png|webp|ico|bmp|mid|midi|wav|rtf|css|js|jar)$ { expires 30d; fastcgi_hide_header "Set-Cookie"; } location ~* /(?:uploads|files)/.*.php$ { deny all; return 404; } location ~ [^/]\.php(/|$) { fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; try_files $uri =404; fastcgi_pass %backend_lsnr%; fastcgi_index index.php; include /etc/nginx/fastcgi_params; include %home%/%user%/conf/web/%domain%/nginx.fastcgi_cache.conf*; if ($request_uri ~* "/wp-admin/|wp-.*.php|xmlrpc.php|index.php|/store.*|/cart.*|/my-account.*|/checkout.*") { set $no_cache 1; } if ($http_cookie ~* "comment_author|wordpress_[a-f0-9]+|wp-postpass|wordpress_no_cache|wordpress_logged_in|woocommerce_items_in_cart|woocommerce_cart_hash|PHPSESSID") { set $no_cache 1; } } } location /error/ { alias %home%/%user%/web/%domain%/document_errors/; } location /vstats/ { alias %home%/%user%/web/%domain%/stats/; include %home%/%user%/web/%domain%/stats/auth.conf*; } location ^~ /shlink/ { proxy_set_header Host $host; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Forwarded-Proto $scheme; proxy_pass http://localhost:8080; proxy_read_timeout 90s; } proxy_hide_header Upgrade; include /etc/nginx/conf.d/phpmyadmin.inc*; include /etc/nginx/conf.d/phppgadmin.inc*; include %home%/%user%/conf/web/%domain%/nginx.ssl.conf_*; } ```