search

shlinkio / shlink

The definitive self-hosted URL shortener
https://shlink.io
MIT License
3.23k stars 259 forks source link

Consider building static error templates #358

Closed acelaya closed 4 years ago

acelaya commented 5 years ago

This would allow depending on zendframework/zend-expressive-renderer and zendframework/zend-i18n only as dev dependencies, reducing the size of the final package and improving the response time for errors.

acelaya commented 4 years ago

The project no longer depends on i18n package, and removing the other one adds some tech-debt as rendering needs to be handled manually, so even though we have a full rendering engine just for a couple of templates, that's better than maintaining a custom solution.