shlomiassaf / ng-router-loader

Webpack loader for NgModule lazy loading using the angular router
MIT License
46 stars 8 forks source link

feat: support webpack 2.4 chunk name annotation for "async-import" #9

Open pglazkov opened 7 years ago

pglazkov commented 7 years ago

Since version 2.4 Webpack supports annotating import() calls with the name of the chunk:

import(/* webpackChunkName: "my-chunk-name" */ "module")

This pull request adds the implementation of adding that annotation comment if the "chunkName" option is provided as part of the route, like so:

loadChildren: 'app/module-container/child-module#ChildModule?chunkName=my-chunk-name'
shaungrady commented 6 years ago

This would be wonderful to have. @shlomiassaf Is this project still being supported?

pglazkov commented 6 years ago

@shaungrady As an alternative you might want to try angular-named-lazy-chunks-webpack-plugin - it automatically generates chunk names based on the module names, so you don't need to add any annotations in code.