shlomiassaf / ngrid

A angular grid for the enterprise
https://shlomiassaf.github.io/ngrid
MIT License
241 stars 40 forks source link

Add RTL support #128

Closed ronnetzer closed 3 years ago

ronnetzer commented 3 years ago

This PR includes several fixes for RTL:

Added an 'Rtl Demo' under demos dropdown, as you can see it's still not perfect: when you scroll down the meta rows flips (I think its the sticky rows, I've tested it with the sellers-example and it was ok)

Also, added an unrelated fix for .pbl-ngrid-row-visually-hidden: when using pbl-ngrid-spacing mixin, the mixin adds a rule that is more specific than .pbl-ngrid-row-visually-hidden which overrides its 0 height/min-height

shlomiassaf commented 3 years ago

@ronnetzer Amazing work

I'll add a dedication documentation page later, instead of the global demo so it will have some documentation!

Thanks!

shlomiassaf commented 3 years ago

As for the sticky issue, the whole sticky rows thing does not fit virtual scrolling anyways, it's not built for that and the CDK will have to undergo a major refactor to support it.

This is why I created the fixed meta-rows model.

I can live with it for now.

BTW, I only see it when I scroll, my guess is that some CSS class that appear on the grid while scrolling does that Or it could be some logic that freezes the top fixed metaheader row while scrolling, pushing it to the end or something.

That's the thing about grid's, so many features need to play along together