search

shlomiassaf / ngrid

A angular grid for the enterprise
https://shlomiassaf.github.io/ngrid
MIT License
241 stars 40 forks source link

Columns with transform throw and break grid #163

Closed ronnetzer closed 3 years ago

ronnetzer commented 3 years ago

What is the expected behavior?

grid should work with transformed columns

What is the current behavior?

grid breaks and throws error in deepPathGet because this being passed is undefined. should replace this with col https://github.com/shlomiassaf/ngrid/blob/0718af8b9e6d24468fb6a95adf891653f650bc74/libs/ngrid/core/src/lib/utils/column.ts#L32

What are the steps to reproduce?

https://stackblitz.com/edit/pebula-ngrid-starter-vg2c8x?file=app/app.component.ts added transform to all columns, you can see that no value is being passed, change the transform to return col and you'll see its not the real col

locally, I receive this error image

Which versions of Angular, CDK, Material, NGrid, OS, TypeScript, browsers are affected?

angular: 11 ngrid: 3.0.0

Is there anything else we should know?

ronnetzer commented 3 years ago

duplicate of #158

shlomiassaf commented 3 years ago

@ronnetzer Release 3.0.1, thank you