search

shlomiassaf / ngrid

A angular grid for the enterprise
https://shlomiassaf.github.io/ngrid
MIT License
241 stars 41 forks source link

MatSort wont trigger Sort.change = true, when using Custom Triggers. #174

Closed Mikeyeli closed 3 years ago

Mikeyeli commented 3 years ago

What is the expected behavior?

MatSort should change the event.sort.change flag to true, when sorting.

What is the current behavior?

MatSort currently fires the event, but the flag remains false.

What are the steps to reproduce?

Add MatSort to the current Infinite Scroll, Custom Triggers example

Which versions of Angular, CDK, Material, NGrid, OS, TypeScript, browsers are affected?

Is there anything else we should know?

I wasn't sure if this was more of a feature request since I'm not sure if this is actually supported.

shlomiassaf commented 3 years ago

Hi

I've just checked it and it does fire the event with changed: true

image

This is when I click on the header to activate sorting

image

Mikeyeli commented 3 years ago

This was my mistake, I was accidentally resetting the source of the grid everytime. This is not an issue!