shlomiassaf / ngrid

A angular grid for the enterprise
https://shlomiassaf.github.io/ngrid
MIT License
240 stars 39 forks source link

When using vScrollNone, grid is not visible when container has height unset or set to auto #226

Open t00 opened 2 years ago

t00 commented 2 years ago

Before upgrade (from 2.x to 4.0) vScrollNone directive worked fine and allowed placing a grid in a normal container without need to set it's size.

After upgrade this directive stopped working. I noticed contain: strict causing this issue on virtual scroll container and implemented a css fix:

.pbl-ngrid-container .cdk-virtual-scroll-disabled {
  contain: unset;
}

Not sure what might be other implications of that fix, but for when virtual scroll is not needed, it seems to do the job.