Angular 2.RC5 Modal 2.0.0-beta.12 'Type' is not generic

[jaroslawziolkowski]

[* ] bug report

• Angular version: 2.0.0-rc5
• Browser: [all]

I based on

• V2: http://plnkr.co/edit/7c0pGE?p=preview and 2.0.0-beta-12

I have module and app same like in plnkr example. My systemjs.config is

/**
 * System configuration for Angular 2 samples
 * Adjust as necessary for your application needs.
 */
(function(global) {
    // map tells the System loader where to look for things
    var map = {
        'app':                        '/app', // 'dist',
        '@angular':                   '/node_modules/@angular',
        'angular2-in-memory-web-api': '/node_modules/angular2-in-memory-web-api',
        'rxjs':                       '/node_modules/rxjs',
        moment:                       '/node_modules/moment',
        'angular2-modal':           '/node_modules/angular2-modal',
    };
    // packages tells the System loader how to load when no filename and/or no extension
    var packages = {
        'app'                       : { main: 'main.js',  defaultExtension: 'js' },
        'rxjs'                      : { defaultExtension: 'js' },
        'angular2-in-memory-web-api': { main: 'index.js', defaultExtension: 'js' },
        'router'                    : { main: 'index.js', defaultExtension: 'js'},
        '@angular/router-deprecated': { main: 'index.js', defaultExtension: 'js'},
        'moment'                    : { main: 'moment.js', defaultExtension: 'js' },
        'angular2-modal':              { defaultExtension: 'js', main: 'bundles/angular2-modal.umd' },
        'angular2-modal/providers'  : { main: 'index.js', defaultExtension: 'js' },
        '@angular/platform-browser-dynamic': { main: 'index.js', defaultExtension: 'js' }
    };
    map['angular2-modal/plugins/bootstrap'] = map['angular2-modal'] + '/bundles';
    packages['angular2-modal/plugins/bootstrap'] =  { defaultExtension: 'js', main: 'angular2-modal.bootstrap.umd' };
    var ngPackageNames = [
        'common',
        'compiler',
        'core',
        'forms',
        'http',
        'platform-browser',
        'platform-browser-dynamic',
        'router',
        'router-deprecated',
        'upgrade'
    ];
    // Individual files (~300 requests):
    function packIndex(pkgName) {
        packages['@angular/'+pkgName] = { main: 'index.js', defaultExtension: 'js' };
    }
    // Bundled (~40 requests):
    function packUmd(pkgName) {
        packages['@angular/'+pkgName] = { main: 'bundles/' + pkgName + '.umd.js', defaultExtension: 'js' };
    }
    // Most environments should use UMD; some (Karma) need the individual index files
    var setPackageConfig = System.packageWithIndex ? packIndex : packUmd;
    // Add package entries for angular packages
    ngPackageNames.forEach(setPackageConfig);

    var config = {
        map: map,
        packages: packages
    };

    System.config(config);
})(this);

When I try run npm start it throw errors

node_modules/angular2-modal/angular2-modal.module.d.ts(16,50): error TS2315: Type 'Type' is not generic.
node_modules/angular2-modal/angular2-modal.module.d.ts(22,44): error TS2315: Type 'Type' is not generic.
node_modules/angular2-modal/models/tokens.d.ts(18,68): error TS2315: Type 'Type' is not generic.
node_modules/angular2-modal/overlay/overlay.component.d.ts(28,61): error TS2315: Type 'Type' is not generic.
node_modules/angular2-modal/providers/modal.d.ts(38,128): error TS2315: Type 'Type' is not generic.

[WenWeiKun-byte]

Having the same issue here with RC5, typescript version 1.8.10.

[jaroslawziolkowski]

I have typescript version 2.1.0-dev.20160907. So far I downgraded it to 1.1.5 and it works. But 2.0 branch still not.

[fahad-nxvt]

Any workaround for version 2?

[shlomiassaf]

Sorry for the delay, not much time this week.

Beta12 is for rc6. In rc6 Type is generic... So running on rc5 will throw...

I have to keep up with angular.

On Sep 7, 2016, at 9:47 AM, Jarek Ziolkowski notifications@github.com wrote:

[* ] bug report

Angular version: 2.0.0-rc5 Browser: [all] I based on

V2: http://plnkr.co/edit/7c0pGE?p=preview and 2.0.0-beta-12 I have module and app same like in plnkr example. My systemjs.config is

/**

• System configuration for Angular 2 samples

• Adjust as necessary for your application needs. */ (function(global) { // map tells the System loader where to look for things var map = { 'app': '/app', // 'dist', '@angular': '/node_modules/@angular', 'angular2-in-memory-web-api': '/node_modules/angular2-in-memory-web-api', 'rxjs': '/node_modules/rxjs', moment: '/node_modules/moment', 'angular2-modal': '/node_modules/angular2-modal', }; // packages tells the System loader how to load when no filename and/or no extension var packages = { 'app' : { main: 'main.js', defaultExtension: 'js' }, 'rxjs' : { defaultExtension: 'js' }, 'angular2-in-memory-web-api': { main: 'index.js', defaultExtension: 'js' }, 'router' : { main: 'index.js', defaultExtension: 'js'}, '@angular/router-deprecated': { main: 'index.js', defaultExtension: 'js'}, 'moment' : { main: 'moment.js', defaultExtension: 'js' }, 'angular2-modal': { defaultExtension: 'js', main: 'bundles/angular2-modal.umd' }, 'angular2-modal/providers' : { main: 'index.js', defaultExtension: 'js' }, '@angular/platform-browser-dynamic': { main: 'index.js', defaultExtension: 'js' } }; map['angular2-modal/plugins/bootstrap'] = map['angular2-modal'] + '/bundles'; packages['angular2-modal/plugins/bootstrap'] = { defaultExtension: 'js', main: 'angular2-modal.bootstrap.umd' }; var ngPackageNames = [ 'common', 'compiler', 'core', 'forms', 'http', 'platform-browser', 'platform-browser-dynamic', 'router', 'router-deprecated', 'upgrade' ]; // Individual files (~300 requests): function packIndex(pkgName) { packages['@angular/'+pkgName] = { main: 'index.js', defaultExtension: 'js' }; } // Bundled (~40 requests): function packUmd(pkgName) { packages['@angular/'+pkgName] = { main: 'bundles/' + pkgName + '.umd.js', defaultExtension: 'js' }; } // Most environments should use UMD; some (Karma) need the individual index files var setPackageConfig = System.packageWithIndex ? packIndex : packUmd; // Add package entries for angular packages ngPackageNames.forEach(setPackageConfig);

  var config = { map: map, packages: packages };

  System.config(config); })(this);

When I try run npm start it throw errors

node_modules/angular2-modal/angular2-modal.module.d.ts(16,50): error TS2315: Type 'Type' is not generic. node_modules/angular2-modal/angular2-modal.module.d.ts(22,44): error TS2315: Type 'Type' is not generic. node_modules/angular2-modal/models/tokens.d.ts(18,68): error TS2315: Type 'Type' is not generic. node_modules/angular2-modal/overlay/overlay.component.d.ts(28,61): error TS2315: Type 'Type' is not generic. node_modules/angular2-modal/providers/modal.d.ts(38,128): error TS2315: Type 'Type' is not generic. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[nadavsinai]

@shlomiassaf if I understand correctly this make 1.1.5 also only for <rc5 ? can we please have a 1.x version for 1.6? we're not ready to hop on the 2.x wagon with the API change... thanks

[shlomiassaf]

@nadavsinai 1.x.x is frozen in time, I will accept PR's but I don't have the resources to maintain it.

[shlomiassaf]

I'll close this as this is not an issue.

@nadavsinai sorry I can't with version 1.x.x, I will gladly accept a PR if you want to work on that. I do however recommend to make the shift towards version 2 as it's more robust.