search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

AoT support #211

Closed shlomiassaf closed 8 years ago

shlomiassaf commented 8 years ago

@isaacplmann This is the PR with you commit inside (squashed)

Please review.

Thanks!

isaacplmann commented 8 years ago

I'll check it out on Monday. Thanks for the hard work.

On Oct 1, 2016 8:05 PM, "Shlomi Assaf" notifications@github.com wrote:

@isaacplmann https://github.com/isaacplmann This is the PR with you commit inside (squashed)

Please review.

Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/shlomiassaf/angular2-modal/pull/211 Commit Summary

  • misc: refactor code base in preparation for AoT support
  • refactor(build): refactor to support AoT

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shlomiassaf/angular2-modal/pull/211, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQIScK7lZIpL12rtrORquoU2WHKSSks5qvvVWgaJpZM4KL5Wv .

isaacplmann commented 8 years ago

Looks good to me. 2.0.0 compiles in the AoT compiler in my app. I'm looking forward to the day when the tooling around ng2 settles down a bit and we don't have to rewrite the build process every 2 months.

isaacplmann commented 8 years ago

I spoke too soon, my app doesn't compile with angular2-modal 2.0.0. I'll file a proper issue in a bit.

isaacplmann commented 8 years ago

Having a tough morning. After clearing the cache, everything is fine. No issue from me.