shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

angular2-modal dynamic component view #346

Open ansuman273 opened 7 years ago

ansuman273 commented 7 years ago

IMPORTANT: Please provide a sample using:

error123

deKaantje commented 6 years ago

@ansuman273 Currently this is the way to render a custom component.

However, I also noticed:

  1. The existence of the component default property as part of the FluentAssign. Although it exists, it does throw an error because of type mismatch, as you mentioned. Implementation seems off.
  2. it does work (partially), even though it's types do not match. It renders the custom component, but lacks the context (which, of course, is necessary).

@shlomiassaf

  1. What is the intention with / roadmap regarding the .component() ? Will this be an easier way to implement a custom component?
  2. If the .component() is not being developed in the near future; how can I use the fluent assign method (for convenience) of, for instance, size/isblocking/ etc. ?