search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

remove dependency on Overlay.defaultViewContainer and fix an issue with lazy-loaded modules #354

Closed pilgylis closed 7 years ago

pilgylis commented 7 years ago

Also with this commit, you are not required to set Overlay.defaultViewContainer = ViewContainerRef anymore.

shlomiassaf commented 7 years ago

Thank you for your contribution.

Due to a huge refactor I could not use the commit but I believe the issue is now fixed with version 3.0.0

If not, please feel free to open a new issue.

Version 3 comes with a better build (FESM) and the following changes:

* handle document for angular universal 
* refactor: use ng-template instead of template
* refactor: remove defaultOverlayTarget directive
* refactor: replace custom swpCmp with ngComponentOutlet

### BREAKING CHANGES

  - Moving to use <ng-template> will break applications running on < 4
  - Applications using defaultOverlayTarget (all of them) will have to omit it

(2f98e75)