search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Fixed install warning when using with angular 4 #356

Closed tobmaster closed 7 years ago

tobmaster commented 7 years ago

During install in an angular 4 project warnings are thrown due to semantic versioning. As the package is angular-4 compatible there was an easy way to prevent this.

warning "angular2-modal@2.0.3" has incorrect peer dependency "@angular/core@^2.1.1".
warning "angular2-modal@2.0.3" has incorrect peer dependency "@angular/common@^2.1.1".
ghost commented 7 years ago

Why won't this be merged :( @shlomiassaf

But @tobmaster you don't address the issue that angular2-modal is using <template> which is deprecated.

shlomiassaf commented 7 years ago

Thank you for your contribution.

Due to a huge refactor I could not use the commit but I believe the issue is now fixed with version 3.0.0

If not, please feel free to open a new issue.

Version 3 comes with a better build (FESM) and the following changes:

* handle document for angular universal 
* refactor: use ng-template instead of template
* refactor: remove defaultOverlayTarget directive
* refactor: replace custom swpCmp with ngComponentOutlet

### BREAKING CHANGES

  - Moving to use <ng-template> will break applications running on < 4
  - Applications using defaultOverlayTarget (all of them) will have to omit it

(2f98e75)