search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Use inline template to avoid bug "file not found ./overlay.component.… #368

Closed troyanskiy closed 7 years ago

troyanskiy commented 7 years ago

Use inline template to have it in umd files.

shlomiassaf commented 7 years ago

Hi

Since this commit on JUN 20 all templates are inlined by the build process.

This is from the umd bundle: image

I guess you probably rebased or something and it wasn't complete.

shlomiassaf commented 7 years ago

@troyanskiy I really don't understand why you insist.

This is a plunker for ngx-modialog version 3.0.3 (after JUN 20): http://embed.plnkr.co/2ppVYl517GI1Byv8vVbG/

As you can see it is working fine (and it's using the UMD bundles)

The image you pasted here shows UMD bundle from the file ngx-modialog.webpack.umd.js which is is not the UMD bundle being used, the actual UMD used is ngx-modialog.rollup.umd.js and this is set in the package.json file.

The webpack UMD bundle is there due to old setup but it's incorrect has a wrong setup and along with not inlining resources it also bundles external packages such as rxjs (due to improper setup).

Even with proper setup the rollup UMD is better in performance and size.