defaultViewContainer no longer exists

shlomiassaf / ngx-modialog

Modal / Dialog for Angular

http://shlomiassaf.github.io/ngx-modialog

MIT License

686 stars 242 forks source link

defaultViewContainer no longer exists #375

Closed ghost closed 7 years ago

ghost commented 7 years ago

IMPORTANT: Please provide a sample using:

I'm submitting a ... [X ] bug report [ ] feature request [ ] question about the decisions made in the repository
Do you want to request a feature or report a bug? BUG

https://github.com/shlomiassaf/angular2-modal/blob/master/QUICKTHROUGH.md

The property defaultViewContainer no longer exists in the latest version. However, I still get the error that I need to set this....

ashfaqch commented 7 years ago

I am also looking for sample code with latest release 3.0.1

Thanks

WeekendMan commented 7 years ago

Got the same issue. Author, I'm sorry, but maybe you should test the things that you're creating?

shlomiassaf commented 7 years ago

Hi,

The source code has no reference to defaultViewContainer and I didn't find any error, warning or info that is thrown/showed due to such state.

Also, the demo app does not set the default view container (it cant...) and no error there...

Can you please provide more info?

ghost commented 7 years ago

@shlomiassaf the QUICKTHROUGH has been removed, and can't reproduce the error anymore. See this plunkr, the reference used to be there:

Guess it's no longer required in the latest version. Closing.

qwe852147 commented 6 years ago

Have the same problem , without defaultViewContainer, I get ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked error.

qazq commented 6 years ago

Got the same issue. I get ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked error.