search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Error in walkthrough #378

Closed millerf closed 7 years ago

millerf commented 7 years ago

Error in walkthrough. I just tried to make a simple example and I get an error on this line:

export class AppComponent {
  constructor(overlay: Overlay, vcRef: ViewContainerRef, public modal: Modal) {
    overlay.defaultViewContainer = vcRef;
  }
...
}

property 'defaultViewContainer' does not exist on type Overlay.

I am using it in ES6 with Angular 4.

It is possible the Overlay has changed since the NG4 update and walkthrough isn't up-to-date?

Thanks.

millerf commented 7 years ago

Now getting some serious bugs in Ionic at compile time... Not sure what it is linked to though...


09:40:20]  ionic-app-script task: "build" 
[09:40:20]  Error: ./src/app/app.module.ngfactory.js Module not found: Error: Can't resolve 
            '../../angular2-modal/plugins/bootstrap' in '/Users/xxxxx/Documents/www/XXXX/mzk_app/src/app' resolve 
            '../../angular2-modal/plugins/bootstrap' in '/Users/xxxxx/Documents/www/XXXX/mzk_app/src/app' using 
            description file: /Users/xxxxx/Documents/www/XXXXX/mzk_app/package.json (relative path:
shlomiassaf commented 7 years ago

Walkthrough haw been removed, the quick start is now in the README.

As for the other error, please open a new issue.