search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

OutsideEventPlugin checks if teardown function is already defined before calling it #379

Closed erzaehlsalex closed 7 years ago

erzaehlsalex commented 7 years ago

In some cases, in the addEventListener method of the OutsideEventPlugin class, the teardown function could be called before actually attaching the event and defining the teardown function, leading to a fn is not a function error, as reported in #239

shlomiassaf commented 7 years ago

Hi

Sorry for the delay.

Can you rebase so I can accept it?

It's nothing much in the code, just file renamed (path moved)

erzaehlsalex commented 7 years ago

I did a rebase, this should be mergeable now.

shlomiassaf commented 7 years ago

Thank you!

erzaehlsalex commented 7 years ago

You're welcome! :)