search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Support for vex-js v4 #384

Closed altschuler closed 7 years ago

altschuler commented 7 years ago

Vex v4 introduced a breaking change in the required DOM structure. The release notes include:

The .vex-overlay element now sits next to the .vex element, instead of as a child.

shlomiassaf commented 7 years ago

Hi

Started working on it see this branch

The change in DOM structure requires a big change in the code and I'm not sure I can support vex backwards.

The branch 95% ready the only issue is with in-element support that seems to be a problem that will require a complete DOM structure change (within the library) in order to support that.

altschuler commented 7 years ago

Fantastic! I'm not sure what in-element support means?

shlomiassaf commented 7 years ago

In the demo app you can see that you can "contain" a modal within an element.

shlomiassaf commented 7 years ago

Have to say, looks like a substantial change, I'll have to see how time it will take.

PRs on that branch are welcome

shlomiassaf commented 7 years ago

Will publish version 4.0.0-beta.2 shortly.

Unfortunately ngx-modialog version 4+ supports Angular 5+ , angular 4 will not work.

This is due to breaking changes in angular 5

altschuler commented 7 years ago

Oh wow, that was fast! Thank you very, very much!

shlomiassaf commented 7 years ago

@altschuler FYI, version 3.0.3 (that works with angular 4) supports VEX 4 now

altschuler commented 7 years ago

Fantastic, just tried it out and it just works :tada: