search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Error with OutsideEventPlugin that would lead to calling undefined function #388

Closed erzaehlsalex closed 7 years ago

erzaehlsalex commented 7 years ago

Hi, this is now the pull request we talked about. Please merge this. Cheers! :)

shlomiassaf commented 7 years ago

@erzaehlsalex Thanks!

I'm rebasing some of master's commits into it so other fixes will get in (mainly support for VEX4)

erzaehlsalex commented 7 years ago

Great! So afterwards you will publish version 3.0.2? Thank you!

shlomiassaf commented 7 years ago

3.0.2 is the latest, I will publish 3.0.3

shlomiassaf commented 7 years ago

It will have a branch now https://github.com/shlomiassaf/ngx-modialog/tree/3.x.x

shlomiassaf commented 7 years ago

ok, publish, hope it works smoothly :)

erzaehlsalex commented 7 years ago

Awesome! I will check it out tomorrow morning and shoot you a message, if everything works smoothly!

erzaehlsalex commented 7 years ago

Works perfect with Angular 4 :)