search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Use inline templates #392

Closed troyanskiy closed 7 years ago

troyanskiy commented 7 years ago

You have closed my PR #368 Seems you still have not inline templates Check file ngx-modialog.webpack.umd.js L: 2935 image

shlomiassaf commented 7 years ago

@troyanskiy I really don't understand why you insist.

This is a plunker for ngx-modialog version 3.0.3 (after JUN 20): http://embed.plnkr.co/2ppVYl517GI1Byv8vVbG/

As you can see it is working fine (and it's using the UMD bundles)

The image you pasted here shows UMD bundle from the file ngx-modialog.webpack.umd.js which is is not the UMD bundle being used, the actual UMD used is ngx-modialog.rollup.umd.js and this is set in the package.json file.

The webpack UMD bundle is there due to old setup but it's incorrect has a wrong setup and along with not inlining resources it also bundles external packages such as rxjs (due to improper setup).

Even with proper setup the rollup UMD is better in performance and size.

shlomiassaf commented 7 years ago

Please close this issue, everything is fine.

troyanskiy commented 7 years ago

@shlomiassaf You are right! I was confused with that webpack and rollup umd's... Using rollup everything is ok.

Thank you!