search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Looking for a new maintainer #414

Open shlomiassaf opened 6 years ago

shlomiassaf commented 6 years ago

This project needs some love, and it's hard for me to find the time required to fully maintain it.

If anybody wants to stand up as a maintainer, please comment here. Thanks!

UPDATE 24/10/2019

2 years and still no maintainer or help found, it's unfortunate, really!

As for today, there are roughly 15,000 monthly downloads for this package, it's a shame for it to fade out.

It was written in the early days of angular and was here before all other alternatives...

Of course, there are other solutions today, some are even better, but I don't think others have the same approach, they are usually UI opinionated.

If you want to help, please message here or PM me.

Thank you guys!

windmaomao commented 6 years ago

@shlomiassaf I'm using your module for about two month now, I'm fairly new to angular2, but has been building libraries and modules for some time. I'd like to give it a try.

shlomiassaf commented 6 years ago

@windmaomao Sure, help is always welcome!

Where would you like to start? we can work together until you feel confidence enough in the angular realm.

xinwangw commented 6 years ago

I just start to include this in the working project, like to help to maintain it. Let me know what I can help.

itsprofcjs commented 6 years ago

Hi @shlomiassaf, I have worked on angular 2 for an year starting from v2 - v5 and would like to be part of this project

keradus commented 6 years ago

As energy and willingness to maintain a project is sth needed for sure, please guys remember that you shall be super familiar with the project in first place. If you are not there yet, maybe start being familiar by helping solving some of 120 issues? I'm just afraid of passing this project to new maintainer that has never touch it so far. It won't help the project.

shlomiassaf commented 6 years ago

Hi guys,

Thank's for the interest.

As @keradus said, only someone familiar with this project can actually maintain it so please those who care, start answering issues and pushing PR's, I will appreciate any kind of help

windmaomao commented 6 years ago

Sorry about the delay. I started to understand this module better.

Yes @shlomiassaf , I agree the best way is to start supporting the module. Kool. Let's see how it goes.

shlomiassaf commented 6 years ago

Thanks First step is to upgrade to v6 including removing the build scripts and moving to angular-cli library build.

Most should be straightforward but the way plugins are structured requires exploration, don't know if the cli support that.

I'll do that and update

Sent from my iPhone

On 1 May 2018, at 18:48, Fang Jin notifications@github.com wrote:

Sorry about the delay. I started to understand this module better.

Yes @shlomiassaf , I agree the best way is to start supporting the module. Kool. Let's see how it goes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Airking17 commented 5 years ago

any updates on this? will the module be updated to be compatible with Angular 7 / 8 soon?

keradus commented 5 years ago

no, switch to material UI and modal available there

Airking17 commented 5 years ago

hmm... this is what I actually tried to avoid, since this module works pretty fine and offers all the functionalities I need.

So no one is maintaining this repo actively?

tayambamwanza commented 4 years ago

@shlomiassaf Noted, why should such a good project go to waste, I think that I will assist but I need to clear my schedule, so you may hear from me sometime next year.

achimha commented 4 years ago

I've been using the project for a number of years in a large project. Now I have decided to remove and replace it. I've looked at maintaining the code but I decided it is best to let the component rest as it is not really needed with today's Angular.

What the component does can be achieved with a lot less code and in a much simpler way with ng-bootstrap. All I had to do was to write a little service that provides the confirm and alert functions with a parameter structure for the options like title and body. It's so little code that it doesn't even warrant a project of its own.

I don't think that a lot of users need this in a UI kit independent fashion and also I don't think the fluent style is an advantage here. It's not common in Angular land and doesn't have much advantage over parameter structures for which Typescript can provide much better code assistance.

The component was great at its time, the code is very well thought out and thanks to @shlomiassaf for providing it.

tayambamwanza commented 4 years ago

@achimha thanks, I also migrated to Ng bootstrap so I think that's the way forward now.