shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 242 forks source link

Compile issue with fullTemplateTypeCheck: true #421

Open achimha opened 6 years ago

achimha commented 6 years ago

Angular 5.2 brings a new AoT compiler option for more thorough template type checking. This option is expected to default to true in the future:

https://blog.angular.io/angular-5-2-now-available-312d1099bd81

Trying to build a project using ngx-modialog with this option set to true, gives errors:

ERROR in node_modules/ngx-modialog/plugins/bootstrap/src/ngx-modialog-bootstrap.ng-flat.d.ts.BSMessageModalBody.html(8,13): : Property 'defaultValue' does not exist on type 'MessageModalPreset'.
node_modules/ngx-modialog/plugins/bootstrap/src/ngx-modialog-bootstrap.ng-flat.d.ts.BSMessageModalBody.html(10,13): : Property 'placeholder' does not exist on type 'MessageModalPreset'.
node_modules/ngx-modialog/plugins/bootstrap/src/ngx-modialog-bootstrap.ng-flat.d.ts.BSMessageModalBody.html(9,13): : Property 'defaultValue' does not exist on type 'MessageModalPreset'.
hishtadlut commented 3 years ago

This is not a fix but if anyone comes to here i handle it by adding

defaultValue: any; placeholder: any;

to: node_modules\angular2-modal\plugins\bootstrap\src\presets\message-modal-preset.d.ts