Angular 6 / RXJS 6 Compatibility

GerritK commented 6 years ago

I'm submitting a ... [x] bug report [ ] feature request [ ] question about the decisions made in the repository
Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Build Errors when upgrading to Angular 6 / RXJS 6

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use one of the templates above as a starting point).

upgrade rxjs to version ^6.0.0(-beta.2)

What is the expected behavior?

building without errors

What is the motivation / use case for changing the behavior?

keeping up to date with the new angular versions

Please tell us about your environment:
Angular version: 6.0.0-rc.0
Browser: all
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

ERROR in ./node_modules/ngx-modialog/plugins/bootstrap/bundle/ngx-modialog-bootstrap.es5.js
Module not found: Error: Can't resolve 'rxjs/operator/combineLatest' in '[...]node_modules/ngx-modialog/plugins/bootstrap/bundle'
ERROR in ./node_modules/ngx-modialog/bundle/ngx-modialog.es5.js
Module not found: Error: Can't resolve 'rxjs/operator/filter' in '[...]node_modules/ngx-modialog/bundle'

The Upgrade Guide can be found here: https://github.com/ReactiveX/rxjs/blob/master/doc/pipeable-operators.md

shlomiassaf commented 6 years ago

Sure, but I'll wait for official first

shlomiassaf commented 6 years ago

PR's welcome

stefan-schweiger commented 6 years ago

For now you can just install rxjs-compat, which as the name suggests is a compatibility layer between RxJS v5 and v6 and everything seems to work fine.

achimha commented 6 years ago

With rxjs-compat, the whole RxJS gets bundled into the application.

shlomiassaf commented 6 years ago

Update: Angular CLI library support is limited at this point.

1) It's very hard to tame it to work with sub-packages (e.g. @ngx-modialog/plugins/bootstrap) 2) It does not support (by design) hot library reloading, i.e. it requires re-compiling and building for every change in the lib then reload the demo app.

I will start working on v6 changes, but again I want to switch this repo to use 100% supported build process so it will probably be nx...

I have to say, that this no hot rebuild thing for libs (2) will not last long the CLI guys will realise it soon enough :)

shlomiassaf commented 6 years ago

ok, repo is angular-cli based, including demo app + libraries and of course cli library build which should make maintenance easier.

I'v also publish to npm, version 6.

There are some issues with the demo site, will work on that.

evgenius1424 commented 6 years ago

Hi, any progress? You are the last reason for rxjs-compat in our large application(

Braus commented 4 years ago

I guess this one is dead after two years no response action :(.

shlomiassaf / ngx-modialog

Angular 6 / RXJS 6 Compatibility #426