search

shlomiassaf / ngx-modialog

Modal / Dialog for Angular
http://shlomiassaf.github.io/ngx-modialog
MIT License
686 stars 241 forks source link

modal does not shows up #427

Closed neo-xy closed 6 years ago

neo-xy commented 6 years ago

took the example 

modal.alert()
    .title('Hello World')
    .body('In Angular')
    .open();

but no modal is showing up (no errors) any idea what can be the reason ? (Angular: 5.0.3)

worldbeater commented 6 years ago

The same issue. Used instructions from readme, plugin hides the scroll bar but does not show any dialogs. So the plugin seems to be broken or outdated and can not be used with Angular 5 right now, need a fix

nch3ng commented 6 years ago

What bootstrap version your project is using? It's v3 or v4? v3 should be working.

If it's v4. Add this in your component in this case.

import { bootstrap4Mode  } from 'ngx-modialog/plugins/bootstrap';
bootstrap4Mode();
worldbeater commented 6 years ago

If it's v4. Add this in your component in this case.

This info should definitely be added to project's readme file to avoid such inconveniences. Thanks a lot for sharing a solution, @qqnc!

nch3ng commented 6 years ago

I think that since now bootstrap v4 has been official. Probably better make bootstrap v4 enabled in default, and some documentations for bootstrap v3.

shlomiassaf commented 6 years ago

Hi guys,

PR's are welcome.

I suggest waiting for my upgrade to V6, then if someone will post a PR that will be great.

Don't have time to manage all issues.

nch3ng commented 6 years ago

Thanks, @shlomiassaf

We all understand your hard working on this project. We'll wait for your upgrade to V6, and see what we can help for the issues. Do you agree to switch to bootstrap 4 as default, and documents for v3?

zios07 commented 6 years ago

@qqnc Thanks ! Your answer helped me.

dbusacca commented 6 years ago

Now I've got this issue with version 6.0.0 and boostrap 3

shlomiassaf commented 6 years ago

closed by #434