shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
454 stars 100 forks source link

Simple Simon solver bug #168

Closed Arcorann closed 4 years ago

Arcorann commented 4 years ago

I notice that when the solver is run in Simple Simon it frequently fails to find a solution even when a solution exists. An example is this saved state from Simple Simon game 98804262199142645760, where the solver fails to find a solution. If the the 7 and 6 of diamonds are moved to an empty column the solver succeeds in finding a solution.

Simple Simon-98804262199142645760_solverfail.zip

shlomif commented 4 years ago

@Arcorann : hi! See this answer. The Simple Simon solver uses meta-moves which may lower its accuracy. I recall that using atomic moves (= a single hegemonous sequence at a time) made it too time&RAM consuming at the time but there may different approaches.

Arcorann commented 4 years ago

Thanks for the link. Looking at the usage page I see that there are a number of presets (many of which are only describe as "a meta-moves preset"). Having tested all the presets, I find that all of them except video-editing solve the game that I posted given its starting state. Testing on other games (such as Baker's Dozen) I also notice that many of the other presets seem much faster than video-editing. Is there any particular reason why video-editing is the default?

shlomif commented 4 years ago

Thanks for the link. Looking at the usage page I see that there are a number of presets (many of which are only describe as "a meta-moves preset"). Having tested all the presets, I find that all of them except video-editing solve the game that I posted given its starting state. Testing on other games (such as Baker's Dozen) I also notice that many of the other presets seem much faster than video-editing. Is there any particular reason why video-editing is the default?

Hi @Arcorann ! Since loading other people's saved games is insecure due to the use of pickle can you please provide a "File -> Export current layout" output (and maybe a screenshot as well)? Also provide details of your OS and how you installed pysol.

Regarding the presets: I presume most of them won't work on Simple Simon as they only work on Freecell-like games. "video-editing" was selected as the default because it tends to yield shorter solutions (at least on Freecell with 4 reserves).

shlomif commented 4 years ago

Closing this issue due to a lack of reply. @Arcorann : I can reopen it again once you provide more info.