shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
460 stars 105 forks source link

Documentation - rules only available in English #235

Open osowiecki opened 2 years ago

osowiecki commented 2 years ago

Hi, do you plan to add translations to the rulesets in the future? The Interface of the application is displayed correctly in polish but rules are all static html files. I believe there should be the option to choose a different set of htmls for different languages (even though the html files themselves don't exist yet).

joeraz commented 2 years ago

I believe someone made a French translation of the documentation at one point, but it's probably a bit outdated now.

That being said, I'd be open to getting a translation of the documentation, but it's not really practical at the moment for a few reasons:

While I can update/review the script to account for alternate translations, in order to actually get the translations, I'd need a volunteer who knows the language well enough to translate the pages and is willing to stick to get any new pages that are added translated as well.

osowiecki commented 2 years ago

I understand. In that case I will wait for a more complete English documentation to show up and than I can offer a polish translation the next time someone asks me for a Solitaire application. I'm setting up a reminder in my calendar to check back again in 6 months. Thanks for all your work.

cardset commented 2 years ago

I think writing the rules from scratch will be to much work and a boring job.

Possible solution: Find a good coder, who is able to read out the variables from the game. Then let the computer create with these variables and the use of some words and phrases the ruleset.

joeraz commented 2 years ago

@cardset I had considered this approach - this is what XM Solitaire does for its game rules. Unfortunately, I don't see this working for PySol. I could pull the game variables easily, but they won't be able to tell the whole story because most of the individual games contain some amount of custom code to handle the games' more unique rules. An automated rule generator would not be able to parse this custom code, and in many cases, the logic in there is key to the game.

shlomif commented 2 years ago

On Wed, 29 Dec 2021 17:15:50 -0800 "Joe R." @.***> wrote:

@cardset I had considered this approach - this is what XM Solitaire does for its game rules. Unfortunately, I don't see this working for PySol. I could pull the game variables easily, but they won't be able to tell the whole story because most of the individual games contain some amount of custom code to handle the games' more unique rules. An automated rule generator would not be able to parse this custom code, and in many cases, the logic in there is key to the game.

there is https://politaire.com/ , but I'm not sure if its source is public and/or GPLv3-compatible.

--

Shlomi Fish https://www.shlomifish.org/ Let’s talk about restores instead of backups - https://is.gd/WatQqu

Cats know what we feel. They don’t care, but they know. — Source unknown, via Nadav Har’El.

Please reply to list if it's a mailing list post - https://shlom.in/reply .

joeraz commented 2 years ago

I'm familiar with Politaire. I believe it's written in JavaScript, so the source should be obtainable if someone was to download the site pages, but I don't think it's officially available anywhere and the main developer died in 2015. I couldn't find any license info, so I can't assume it's GPL compatible. But I'm pretty sure that the documentation there was not auto-generated.

Probably mostly useful as a reference to confirm game rules.

cardset commented 2 years ago

From politaire.com

Politaire has detailed game rules pages for every single game. Admittedly, they are all programmatically generated from the option settings, so they can be a bit robotic in style,

joeraz commented 2 years ago

Okay, completely missed that. I think I was thrown off a bit by how there are some sections of their rules that were written by a human (describing history and sources for the games).

Looking closer, with Politaire, all of the games are generated by a set series of variables, which can be set by an Option menu similar to the Solitaire Wizard. This is similar to XM Solitaire, where the game rules are determined by XML variables. I could see this being useful if we wanted to make rules for Solitaire Wizard games, but it wouldn't work for games that contain unique rules or custom code (and most of them do).

joeraz commented 2 years ago

As of today, the documentation now contains a set of rules for every game in PySolFC. Though they could use copyediting and review for clarity. So it should be easier to go ahead with translating if anyone wants to.

That being said, I plan to start adding new games again after the 2.18 release, and may add other pages to the documentation too, so there will always be more pages added later.