search

shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
454 stars 100 forks source link

Hints #291

Closed hajo4 closed 1 year ago

hajo4 commented 1 year ago

When requesting a hint, pysol keeps track, and at the end shows a message like "Game finished, but not without my help...".

I would like to have this more detailed, ie. how many hints were requested, and how many suggestions were made.

I mean, if the game cannot give a hint, it shouldn't count as 'help'...

Also, it might be nice to have a count of possible moves displayed in the statusline, for Spider, Picture-Gallery, etc. or on the table-background, as in Mahjongg.

joeraz commented 1 year ago

I don't think a hint not finding any possible moves means that the hint failed - you do still get a hint, it's just the hint is telling you there are no possible moves and you need to redeal, and you're still checking if there's an available move you missed. Though I personally always felt the way hints were handled was a bit heavy-handed, hence why I added the Free Hints option.

PySol does keep track of the number of hints used (in the Status window), so I should be able to add that to the game end message.

joeraz commented 1 year ago

Okay, that last commit should add a hint count to the completed game with help message.

joeraz commented 1 year ago

Confirmed that if using a hint doesn't find a move, it doesn't count against the player. Same as if you use other assist options, like highlighting same rank, etc.