shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
445 stars 97 forks source link

Spider: Stuck notification pops up when not stuck (yet) #340

Open FoobarTheFatPenguin opened 8 months ago

FoobarTheFatPenguin commented 8 months ago

Hi!

While playing Spider variant games, I can provoke what I believe to be a premature stuck notification.

Screenshot: https://imgur.com/a/ie5bJom

As you can see, I still have cards left on the talon. I could split one of the already sorted piles to fill the empty spaces and then draw more cards from the talon. But the game tells me I'm stuck (and the hint function also has no solution).

The conditions appear to be:

I can just click "Cancel" then proceed to split a deck and keep playing, eventually solving the puzzle. Therefore, I think it's wrong to tell me I have no more moves left.

PySolFC version 2.21.0 (Linux Flatpak)

joeraz commented 8 months ago

The lack of hint would explain this. The stuck checker would consider a situation where no hints have been identified, and it's not possible to draw from the talon, as a stuck game.

Rewriting the spider hints to account for this scenario should fix the issue.