shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
445 stars 97 forks source link

Feature request: Media controls for music #343

Open FoobarTheFatPenguin opened 8 months ago

FoobarTheFatPenguin commented 8 months ago

I have come to like the background music feature. Sometimes, however, I wish I could repeat a track. At other times, the playback seems stuck in a loop (one song repeating over and over and over - haven't found a way to reproduce yet). In those cases, I wish I could just skip to the next track.

I think it would be cool if users could add some simple media controls to the toolbar (play/pause, stop, next, previous). Displaying the name of the file that is currently playing in the status bar would also be helpful.

Just a suggestion. I understand this is not part of the core functionality of the program and thus probably not of the highest priority.

joeraz commented 8 months ago

You use to be able to use Control+U to advance to the next song - I think that was broken in some of the recent releases, but I've already fixed that for the next one.

My issue with putting it in the regular toolbar is that I feel some of the options could be confusing - it might be tough to distinguish between "pause game" and "pause song" for example. I could see about making a separate toolbar, or even a music player window similar to the find card dialog. Will need to think this one over.

FoobarTheFatPenguin commented 8 months ago

How about making it clear via the icon, e.g. by adding a music note next to the play/pause/stop/next/prev symbols.

Quick example sketch: mediacontrols

joeraz commented 8 months ago

Yes, but if we have to create unique icons, we'd need to create them for each size and toolbar style.