shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
445 stars 97 forks source link

Hanafuda Four Seasons Win Not Recognized #354

Closed ThickMcPunchhard closed 3 months ago

ThickMcPunchhard commented 6 months ago

Hanafuda Four Seasons will repeatedly say you are stuck, but the game is possible to solve. Once solved, it does not recognize the game as a win. Image is the game I finished with after being told I was "stuck" 5 or 6 times with no recognized win. "Stuck" message often happens when there is an empty row, but also during moves when all rows have at least one card. Happens both on Android and Windows. Screenshot 2023-12-13 132838 Screenshot 2023-12-13 131821

joeraz commented 6 months ago

In Hanafuda Four Seasons, the sequences have to be placed in the correct hanafuda suit order for the game to be won.

ThickMcPunchhard commented 6 months ago

Thank you for the update, I'm new to this kind of game. It would be great to have the suit order in the game rules. I still can't find that after going back and looking at them, the General Hanafuda Rules, General Rules, Glossary, or Fan Rules links that are in the instructions. I tried Demo about 20 times, but they all wouldn't "come out" and stopped.

joeraz commented 6 months ago

The suit order is a trait of Hanafuda decks, and is important in many Hanafuda deck games - it's mentioned in the general hanafuda rules page, but I can try to update the doc for clarity.

This image shows the correct suit order: hanahelp

joeraz commented 3 months ago

I added another section to the Hanafuda general rules page to provide a little more clarity on the order of the suits, and its importance to the games.

This should hopefully help alleviate the confusion.