shlomif / PySolFC

A comprehensive, feature-rich, open source, and portable, collection of Solitaire games.
http://pysolfc.sourceforge.net/
GNU General Public License v3.0
445 stars 97 forks source link

Broken Card Dealing in Spider (2 Suit) #369

Closed mchieek closed 1 week ago

mchieek commented 2 weeks ago

In the 2-Suit Spider game, the deal cards action (by pressing the new stack) is broken. The stack will show that there are still cards left to be dealt, but when it is pressed, no cards are dealt. Thus, the game can't be continued. This doesn't happen every time, but once every few games. Everything else looks the same and functions normally.

joeraz commented 2 weeks ago

Can you confirm that there aren't any empty piles when you're trying to deal cards?

mchieek commented 2 weeks ago

Hello,

There were empty piles when I tried to deal cards, because it was the end of the game...

Thank you

On Mon, Jun 10, 2024 at 1:55 AM Joe R. @.***> wrote:

Can you confirm that there aren't any empty piles when you're trying to deal cards?

— Reply to this email directly, view it on GitHub https://github.com/shlomif/PySolFC/issues/369#issuecomment-2156907798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVHH7FZXZR64IRRPVAHUPYLZGTTO7AVCNFSM6AAAAABJBIHMV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWHEYDONZZHA . You are receiving this because you authored the thread.Message ID: @.***>

joeraz commented 2 weeks ago

Then this is not a bug. As per the rules of Spider, you're not allowed to deal cards if there are empty piles. You either have to split your remaining stacks to fill the empty piles or deal the next set of cards before making your last sequence to continue the game.

joeraz commented 1 week ago

As this appears to be a non-issue, I'm closing this - if you can provide a save game file where you cannot redeal where there are no empty piles, I will reopen and investigate.

Though this isn't the first time someone reported this as an issue. I'll make a note to add this to the FAQ page next time I update it.