search

shlomif / fc-solve

Freecell Solver - a C library for automatically solving Freecell and some other variants of card Solitaire
https://fc-solve.shlomifish.org/
MIT License
58 stars 12 forks source link

remove Python2 support #102

Closed a-detiste closed 1 month ago

a-detiste commented 1 month ago

we are trying to slowly remove six from distributions

shlomif commented 1 month ago

@a-detiste : hi! The patch looks acceptable, so I'll try to get to applying it soon. Thanks!

shlomif commented 1 month ago

@a-detiste : merged, thanks!

a-detiste commented 1 month ago

Hi, should I propose the same for PySolFC ?

shlomif commented 1 month ago

@a-detiste : re PySol FC use of "six.py" for supporting Python 2: I'm not sure it will be recommended to remove it. This is given PySol FC is commonly deployed to MSWindows and macOS desktops.

@joeraz : what do you think?

joeraz commented 1 month ago

Frankly, I've been wanting to drop Python 2 support for a while. Just never got around to asking.

I do have a Windows test environment, and I run it with Python 3 there. Though I don't have a Mac environment, the script that generates the Mac packages also uses Python 3. My only uncertainty was if some obscure Linux distro needed it, but there are a couple longstanding bugs when running in Python 2 that never got reported, so I don't think Python 2 support is being used.

Feel free to open an issue on the main PySolFC repo.

shlomif commented 1 month ago

@joeraz : thanks for your informative reply