search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Fix setNamespace to set the empty namespace correctly #10

Closed choroba closed 6 years ago

shlomif commented 6 years ago

Hi @choroba ! thanks for your contribution. Please revise like this:

  1. Convert it to <<return $self ... ? 1 : 0;>> - in two places

  2. Add https://metacpan.org/pod/Test::Count "# TEST" annotations to the new assertions.

Thanks!

choroba commented 6 years ago

I created two fixups. If you're OK with them, I'll squash them.

shlomif commented 6 years ago

@choroba : looks good - go ahead. Thanks!

choroba commented 6 years ago

Done.

shlomif commented 6 years ago

Merged, thanks!